Embedded Loop

#1 Oct 30, 2012

_ForgeUser4409688

Join Date: 5/9/2010
Posts: 7
Member Details

So I got this embedded loop error in my code and I am not sure what causes it. I have tried a lot like making extra variables for the picked units. What I am trying to do is search for units of the type buff around a buff respawn (the unit Powerups). Then if there is a unit nearby the custom value 2 of Powerups should be increasing until it reaches a certain value and respawns another one. Maybe there is an even simpler way of doing it? Sorry for the long post but there was no option to use a spoiler.

Code

//--------------------------------------------------------------------------------------------------
// Trigger: Respawn Buffs
//--------------------------------------------------------------------------------------------------
bool gt_RespawnBuffs_Func (bool testConds, bool runActions) {
    // Variable Declarations
    unit lv_buffSpawnerpick;
    unit lv_buffpick;
    int lv_buff;

    // Variable Initialization
    lv_buffSpawnerpick = null;
    lv_buffpick = null;
    lv_buff = 0;

    // Actions
    if (!runActions) {
        return true;
    }

    UnitGroupLoopBegin(UnitGroup(UnitTypeFromString("Powerups"), c_playerAny, RegionEntireMap(), UnitFilter((1 << c_targetFilterPsionic) | (1 << c_targetFilterStructure), 0, 0, 0), 0));
    while (!UnitGroupLoopDone()) {
        lv_buffSpawnerpick = UnitGroupLoopCurrent();
        lv_buff = 0;
        UnitGroupLoopBegin(UnitGroup(UnitTypeFromString("Buff"), c_playerAny, RegionCircle(Point(PointGetX(UnitGetPosition(UnitGroupLoopCurrent())), PointGetY(UnitGetPosition(lv_buffSpawnerpick))), 2.0), UnitFilter((1 << c_targetFilterRobotic) | (1 << c_targetFilterPsionic), 0, 0, 0), 0));
        while (!UnitGroupLoopDone()) {
            lv_buffpick = UnitGroupLoopCurrent();
            lv_buff = 1;
            UnitGroupLoopStep();
        }
        UnitGroupLoopEnd();
        if ((lv_buff == 0)) {
            UnitSetCustomValue(lv_buffSpawnerpick, 2, (UnitGetCustomValue(lv_buffSpawnerpick, 2) + 1.0));
        }
        else {
        }
        if ((UnitGetCustomValue(lv_buffSpawnerpick, 2) >= 8.0)) {
            UnitSetCustomValue(lv_buffSpawnerpick, 2, 0.0);
            libNtve_gf_CreateUnitsWithDefaultFacing(1, "Buff", 0, 15, UnitGetPosition(lv_buffSpawnerpick));
        }
        else {
        }
        UnitGroupLoopStep();
    }
    UnitGroupLoopEnd();
    return true;
}

//--------------------------------------------------------------------------------------------------
void gt_RespawnBuffs_Init () {
    gt_RespawnBuffs = TriggerCreate("gt_RespawnBuffs_Func");
    TriggerAddEventTimePeriodic(gt_RespawnBuffs, 1.0, c_timeGame);
}

//--------------------------------------------------------------------------------------------------

#2 Oct 30, 2012
rageninpo
rageninpo

View User Profile

View Posts

Send Message
- Join Date: 5/27/2010
- Posts: 2,477
- Member Details
@Zer0kx: Go

You can not use pick each unit within itself...

same goes for pick each player

or any pick each

You need to switch it to use..... unit i of unit group
It is pointless to set a variable to = picked unit unless you are going to refer to that unit after the loop. Which you are not doing.

Why are you looping through all your power ups on the map? I would think theres more effienct ways for doing something similiar

to re-spawn your buffs. make a unit that has a behavior that spawns your power ups. I see from your code your spawning them through triggers. change it to do it all from data
to detect units near power ups, give the power up a behavior that does an effect to all unit in the search area around itself. Detect this effect being using from a trigger and do what ever custom value changing you need to do at that point. if you really don't need to change the custom value you may be able to just have each power up apply a buff behavior to the units in range. This behavior can be stack-able to indicate that the unit is in range of multiple power ups.

this way you avoid having to loop through all the shit anyways....
Last edited by rageninpo: Oct 30, 2012

Rollback Post to Revision RollBack

Skype KageNinpo = SN My Libraries DialogLeaderboard & TeamSort My Projects SPACEWAR Tribute Infinite TD
To post a comment, please login or register a new account.

Previous Thread

Next Thread