2 questions to community - Triggers - Development - SC2 Mapster Forums

#1 May 11, 2013

_ForgeUser10434023

Join Date: 1/22/2013
Posts: 105
Member Details

1 question: I have a trigger, trigger make starcraft freeze when triggering units are dead(number of them = 0), and var Goverment Form[PxUSER] != 0 I even know exactly what part makes this, I just cant understand why its no responding:

Player 4 reducing corruption mechanic
    Events
        Unit - Any Unit dies
        Unit - Any Unit construction progress is Completed
        Dialog - Any Dialog Item is used by Player {Any Player} with event type Clicked
    Local Variables
    Conditions
        Goverment Form[P4USER] != 0
    Actions
        General - While (Conditions) are true, do (Actions)
            Conditions
                (Number of active instances of (Current trigger)) <= 1
                (Number of Living units in (Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) > 0
                And
                    Conditions
                        (Number of Living units in (Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) == 0
            Actions
                General - Wait {30.0} Game Time seconds
                UI - Display {"Our Palaces has helped to reduce Co..."<s val="Swarm_Achievement_Tooltip_Title"><c val="00FF00">(-(Text((Count of Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3))))</c></s>} for (Player group(P4USER)) to Subtitle area
                Variable - Modify Government_Corruption_Level[P4USER]: - (Count of Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3)
                General - If (Conditions) then do (Actions) else do (Actions)
                    If
                        Government_Corruption_Level[P4USER] < 0
                    Then
                        Variable - Set Government_Corruption_Level[P4USER] = 0
                    Else
                General - Wait for (Conditions), checking every 3.0 Game Time seconds
                    Conditions
                        Government_Corruption_Level[P4USER] > 0
        General - While (Conditions) are true, do (Actions)
            Conditions
                (Number of active instances of (Current trigger)) <= 1
                (Number of Living units in (Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) == 0
                And
                    Conditions
                        (Number of Living units in (Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) > 0
            Actions
                General - Wait {30.0} Game Time seconds
                UI - Display {"Our Courthoses has helped to reduce..."<s val="Swarm_Achievement_Tooltip_Title"><c val="00FF00">(-(Text((Count of Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3))))</c></s>} for (Player group(P4USER)) to Subtitle area
                Variable - Modify Government_Corruption_Level[P4USER]: - (Count of Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3)
                General - If (Conditions) then do (Actions) else do (Actions)
                    If
                        Government_Corruption_Level[P4USER] < 0
                    Then
                        Variable - Set Government_Corruption_Level[P4USER] = 0
                    Else
                General - Wait for (Conditions), checking every 3.0 Game Time seconds
                    Conditions
                        Government_Corruption_Level[P4USER] > 0
        General - While (Conditions) are true, do (Actions)
            Conditions
                (Number of active instances of (Current trigger)) <= 1
                (Number of Living units in (Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) > 0
                And
                    Conditions
                        (Number of Living units in (Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) > 0
            Actions
                General - Wait {30.0} Game Time seconds
                UI - Display {"Our Courthoses and Palaces has help..."<s val="Swarm_Achievement_Tooltip_Title"><c val="00FF00">(-(Text({(Count of Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3)+(Count of Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3)})))</c></s>} for (Player group(P4USER)) to Subtitle area
                Variable - Modify Government_Corruption_Level[P4USER]: - {(Count of Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3)+(Count of Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most 3)}
                General - If (Conditions) then do (Actions) else do (Actions)
                    If
                        Government_Corruption_Level[P4USER] < 0
                    Then
                        Variable - Set Government_Corruption_Level[P4USER] = 0
                    Else
                General - Wait for (Conditions), checking every 3.0 Game Time seconds
                    Conditions
                        Government_Corruption_Level[P4USER] > 0
                General - While (Conditions) are true, do (Actions)
            Conditions
                (Number of Living units in (Palace (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) == 0
                And
                    Conditions
                        (Number of Living units in (Courthouse (Max 3) units in (Entire map) owned by player P4USER matching Excluded: Missile, Under Construction, Dead, Hidden, with at most Any Amount)) == 0
            Actions
                Trigger - Stop all instances of (Current trigger)

Last block with if-then-else makes starcraft freeze, and not response absolutely, trigger still work enough without this, I only wonder why its happens

2 question:

Cause I bad with functions and dont speak eng(only write, so I dont use tutorial videos), I make triggers for each player. If I will use functions does it reduce overall lag? And cause I cant figure them out, If someone will can link me tutorial (not video I bad with speak eng)about making functions for p1p2p3... i will glad, or will add there example what are parametrs I need use and for what they are.

Last edited by _ForgeUser10434023: May 11, 2013

#2 May 11, 2013

hobbidude

Location:
Join Date: 9/29/2010
Posts: 615
Member Details

Yes custom definitions will generally reduce lag and speed things up provided they are setup correctly. Custom definitions come in both action definition and function definition form with the major difference being functions allow you to return information back through to the trigger or original defintion that it is used in (ie you can have many definition inside of one another). Functions are particularly useful in doing things like taking in a number and returning a unit type based on the number, which you can then use in mulitple triggers without have to copy your work. Parameter is what allow you to pass the information you need from the trigger into the definition. Also if your using them for things like on a per player bases you should not be using multiple definitions/triggers for each player; you should be using a integer loop to cycle through each player which is then used in the parameter of your definition. If you then check the "create thread" checkbox within the defintion it will then allow multiple thread to run simultaneous, so in the example every player would be done at the same time instead of one of a time.

When I want your opinion...I'll give it to you!

#3 May 12, 2013

_ForgeUser10434023

Join Date: 1/22/2013
Posts: 105
Member Details

@hobbidude: Go

What about if I need different vars or numbers for each player? i.e. if trigger

if var_p1user = 1 then set var2_p1user = true
if var_p2user = 1 then set var2_p2user = true
....
if var_p1user = 2 then set var2_p1user = false
if var_p2user = 2 then set var2_p2user = false

in that case better triggering player or integer loop? if I set in conditions triggering player p1user then I can set in all actions for this condition p1user as triggering player? does it will correct work between players, I mean I no need trigger executing with many players instantly?

Last edited by _ForgeUser10434023: May 12, 2013

#4 May 12, 2013

willuwontu

Curse Premium

Location: sacramento
Join Date: 11/17/2012
Posts: 1,083
Member Details

Trigger: Rawr
events: Whenever
Local Variables:
x = 0 <integer>
conditions: i feel like it
actions:
General - For each integer x from 1 to 15 with increment 1
Actions:
If
(Custom function (x)) == true
then
custom action(x)

Custom function
- options: Function
- Return type: Boolean
Parameters
- Player = 0 <integer>
Actions
If 
Player Player status == user
then
return true
else
return
false

Custom Action
- Options: action
- Return type: (none)
Parameters:
- Player = 0 <integer>
Actions:
Modify Player Player minerals set to 1000
Modify Player Player vespene set to 2000
Wait 5 game time secs
Display "Willuwontu is really awesome" to the Directive area for player group(player)

That is the bare bones of a trigger and how to call custom functions and actions in it. One of these days i might create a demo map with example in it.

Essentially what you need to do is

create the function or action you want, with the parameters you need
then call the action or function and set that parameters to what you want.

P.S. I made a boo boo when making this, typically I set a variable to the parameter, then use the variable, in case i need to modify it throughout the action.

Last edited by willuwontu: May 12, 2013

Still alive and kicking, just busy.

My guide to the trigger editor (still a work in progress)