SC2Mapster

IncomeTest
    Events
        Unit - (Triggering unit) Enters P1BuildArea
    Local Variables
    Conditions
        (Unit type of (Triggering unit)) == Nexus
    Actions
        Player - Modify player (Triggering player) Minerals: Add 1

for some reason this fires 1 time and thats it. how can i get this to constantly run?

IncomeTest
    Events
        Unit - (Triggering unit) Enters P1BuildArea
    Local Variables
    Conditions
        (Owner of (Triggering unit)) == 1
        (Unit type of (Triggering unit)) == Nexus
    Actions
        General - Pick each integer from 1 to 1,000,000,000, and do (Actions)
            Actions
                General - Repeat (Actions) (Picked integer) times
                    Actions
                        Player - Modify player (Triggering player) Minerals: Add 1
                        General - Wait 1.0 Game Time seconds

LMFAO is there a better way than this? haha seems ugly but it works.

@tdhsst:

dont use pick/for each integer. it creates horrible and inefficient code in galaxy that will eat up your script limit.
easiest way would be

While - Triggering Unit is in Region(P1BuildArea) = True
Add 1 mineral
wait 1 second

@maverck:

i will surly change it if the script limit or game lags because of the extreme amount of computer data.

@Trieva:

guess its like doubling down on the triggering unit to have it in 2 spots then. also sorta was thinking if i had it as ANY UNIT then it would fire as long as even a zealot was present, lol. but i think thats where the conditions comes in.

thanks for the feed back :D

Quote from zeldarules28: Go

Event- Periodic Event (1 second)

Never, ever, ever do this. Ever. Use a loop instead.

@BasharTeg:

    Events
    Local Variables
    Conditions
    Actions

How exactly to do the loop instead? :D

http://lmgtfy.com/?q=sc2+trigger+loop+tutorial

@hobbidude:

Assimilator
    Events
        Unit - Any Unit Enters (Entire map)
    Local Variables
    Conditions
    Actions
        General - Pick each integer from 1 to 8, and do (Actions)
            Actions
                General - While (Conditions) are true, do (Actions)
                    Conditions
                        (Owner of (Triggering unit)) == (Picked integer)
                        (Unit type of (Triggering unit)) == Assimilator
                    Actions
                        Player - Modify player (Triggering player) Minerals: Add 10
                        General - Wait 1.0 Game Time seconds

Cleans up alot of space.. got 3 triggers instead of 3x8=24 triggers. one for assimilator,refinery, extractor and it covers all players :D thanks.