SC2Mapster

Okay.. So I was playing around with the mouse movement event. I used the event to update mouse cursor position, and I used a separate trigger (Attached below) to move a unit according to preset velocity/acceleration gradients. Here's the problem.. Whenever I hover my cursor too far to the left or right of the screen and allow the trigger below to do it's work, it's thread just magically terminates for no reason (after the unit arrives at the map border).. No error message, nothing :( You may notice a debug message at the bottom that says "Terminate". Even that doesn't display... Thus the whole thing is breaking without the while loop condition failing.

This has got me baffled and will probably keep me up tonight.. If anyone could provide some help on the matter as to how I can stop the thread terminating prematurely, I would appreciate it. I've gone through this code lot's of times but I don't see any reason why it should be failing... I've attached the map as a reference.. The trigger is located under Movement > t_Movement

PS: I got confirmation that the thread terminates with the trigger debugger window. And also please note.. If running in window mode, the attached map will lag because of the influx of events...

//Moves unit - own thread
bool MoveUnit(bool tc, bool ra){
    //Vars
    int p = g_pMove;            //Player
    unit u = s_move[p].u;       //Unit
    point pnt;                  //Buffer point
    point pntf;                 //Final point
    point pnti;                 //Initial point
    fixed dp;                   //Distance between points
    fixed dx;                   //Diff x
    fixed dy;                   //Diff y
    fixed a;                    //Angle
    fixed v = s_move[p].vi;     //Current velocity   
    int i = 0;

    //Actions
    while(PlayerStatus(p) == c_playerStatusActive){
        pntf = s_move[p].pnt;
        pnti = UnitGetPosition(u);
        dp = DistanceBetweenPoints(pntf,pnti);
        i+=1;
        tDebug(i2s(i));
        //Compare points
        if(dp != 0){
            dx = PointGetX(pntf) - PointGetX(pnti);
            dy = PointGetY(pntf) - PointGetY(pnti);
            a = ATan(dy/dx);
            //4 Quadrant correction
            if(dx < 0){
                a = a + 180;
            }
            pnt = pnti + Point(v*Cos(a), v*Sin(a));
            if(dp > 8){
                //Increase velocity
                v = clampF(v+s_move[p].a, s_move[p].vi, s_move[p].vf);
            }else if(dp > 4 && dp <= 8){
                //Do nothing
            }else if(dp > v && dp <= 4){
                //Decrease velocity
                v = clampF(v-s_move[p].a, s_move[p].vi, s_move[p].vf);
            }else{
                pnt = pntf;
            }
            tDebug("d: "+f2s(dp,4)+", a: "+f2s(a,4)+", v: "+f2s(v,4));
            //Move unit
            UnitSetPosition(u, pnt, true);
        }
        Wait(0.0625,c_timeGame);    //Restrict movement
    }
    tDebug("Terminate");
    return true;
}

Additional Info:

• clampF: Clamp fixed value
• tDebug: Print debug message
• s_move[p] is a struct that stores the players movement config.

Urgh.. Found the culprit.

a = ATan(dy/dx);

Divide by 0 =_=

I shall go bang my head on the wall now...

This thread is the definition of irony.

Quote from Mozared: Go

This thread is the definition of irony.

The thought of this actually made me burst out in laughter :D

Is there a reason you used Atan(dy/dx) instead of Atan2(dy, dx)?

@Deaod: Go

No particular reason, except that I overlooked the ATan2 function.

What's the difference though?

I'm guessing it is able to detect divide by zero and spit out Inf, since ATan2 calculates dy/dx within it, Whereas with ATan, dy/dx is calculated, then passed as a parameter to the ATan function

@FuzzYD: Go

It also does the quadrant correction automatically, afaik.

€ http://en.wikipedia.org/wiki/Atan2

@Kueken531: Go

If it settles quadrant correction, it sounds like an awesome function. I'll certainly start using it.