So the issue I am having is trying to use wc3 data mod to change harvest amount. There will be 5 different workers and the only thing that changes is the amount at which they return per "cargo" or "lumber stack" which appears to be controlled by the number of behavior stacks on the unit. Scroll down for a TL;DR :D
Things I want:
1) The 5 different workers will have different harvest amount per stack of lumber. But everything else should be the same, including the behavior and effects to get the stacks of lumber and the processes involved. (Or so I think)
2) I will have 3 upgrades that change the amount that is harvested. Which I could do in upgrades that change the effect "super worker lumber 1" and "worker lumber 1" Basic Effect: Resources to the new value per upgrade. (I've only listed 2 because I haven't done the other 3 because I am trying to at least get the super worker to work correctly). Since each worker will only hit the tree 10 times, I have to hard 'code' the harvested values because some will have decimals and I haven't have .5 behavior on a unit.
4) A person should be able to right click a tree to initiate the harvesting or by clicking the ability. Both of these work in wc3 and in sc2. I've figured out that both "Worker Harvest Lumber" and "Worker Harvest Lumber Directed" must be in the abilities for the unit to achieve this result. I've tried to merge the two without any luck. Also I wanted the return of cargo to not be displayed unless you actually have cargo, which "Worker Harvest Lumber Return Search" does, but without the "Worker Harvest Lumber Return" it will get an error. Effectively all 4 of these abilities need to be on the unit with only "Worker Harvest Lumber Directed" and "Worker Harvest Lumber Return Search" being used in the command card.
5) Only the peasant "Worker" has the animation of lumber on his shoulder, the rest do not, but they have the attack animation of attacking the tree. I think I've done this correctly.
* 6) Not really something I want to change or even would even matter, but Blizzard set the harvest ability to damage the tree, I changed it to do 0 damage to a tree, thus never killing it and allowing it to be harvested for an infinite amount. However they also include a "tree dead" validator and effect, which seems useless to me since it will never die. I don't know if removing this will change things, but I do not care too much since it won't affect the process at all in this scenario.
Methods tried:
1) I've tried copying the whole peasant unit (which I called "worker" now) including all effects and behaviors after I tested the command card and abilities and the "worker" does exactly what I want it to do. The copying didn't copy some of the sub effects, sub validators, etc. so I had to just copy the ones that were missing and relink them. After that was done I tried putting the new abilities on the "super worker" unit. The "super worker" does 'attack' the tree but it doesn't return or even get lumber. I assume it's because the behavior isn't being applied.
2) I've instead tried to do a smarter approach. Since the only thing that differs between the 5 workers are the amount in which they gather, I've tried to change the effects inside the ability "worker harvest lumber return" as it is that ability that actually sets the lumber you get based on the stacks of lumber harvested. So using the last method I had the copy of the "Super worker lumber 1 set" effects. I then tried to put a unit type validator on that effect should only use that effect if the unit type is what I want. The same probably occurs as the last one, the "worker" works fine, but the "super worker" does not.
3) I've also tried to create my own to simplify Blizzard's way of doing this process but I cannot seem to grasp the moving parts of all of this :(
I've included the test map that diverged from the original which is basically the same without 1 ability that I removed, I think it was "Worker Harvest Lumber Return" as I merged it with the "Worker Harvest Lumber Return". Also The "Super Worker" has the attack animation to the tree and if I right click a tree it will activate the harvest process. It just doesn't return it.
TL;DR: I want to be keep the method in which 5 different workers harvest trees. The only thing I want to change is how much they harvest, but the method stays the same. I assume a validator needs to be used, which I tried but the "Super Worker" doesn't return cargo, or even have cargo like the "Worker" does.
Thank you DrSuperEvil for you response. However that doesn't solve the issue of 5 different units harvesting different amounts and how to link it to what Blizzard has set.
1) Isn't unit dependant. It is based off the ability, Blizzard has wc3 units split their gather and return cargo. Even if I were to change that field, it would only change the ability's bonus which would be applied on all 5 units.
2) The ability harvest basically applies a buff. When it has max lumber stacks (10) it will return the cargo. Then the buff is counted which is basically how many stacks of lumber it has. And it somehow checks and matches with the effect "worker lumber x", where x is a number and it will give lumber to the player based on what is inside "worker lumber x set". This is a simplified way of what it is doing but there are effects upon effects and I'm not sure what it does.
4) I'll try smart command.
5) I'm not saying I want the bundle, just that other units should not have it.
Visualization of the mess. Note that the workers have TWO(Worker Harvest Lumber, Worker Harvest Lumber Directed) mining abilities but one ONE(Worker Harvest Lumber Directed) has a button that can be clicked. I think what isn't working is Carry Lumber behavior not being applied to the unit Super Worker, because the button for the return cargo doesn't show up. Link to download excel spreadsheet
Yes, both workers use the same 4 abilities. Yes, there are unit type validators that I put in for the return cargo. However unit type validators aren't anywhere else. Upon testing, using triggers to give the buff to the worker, it doesn't return. However it can't be because of the validator because the regular worker still works, but the super worker does not return. The button to return cargo doesn't even show up.
Edit: I think the problem lies somewhere in "Worker Harvest Lumber Return Search" If I remove the unit type validator the super worker will harvest like the regular worker. However the button still doesn't appear and I don't want it to mine like the regular worker.
I have appeared to narrow it down by a lot. "Worker Harvest Lumber Return Search" seems to be where the issue is coming from. I have played around with things and now the super worker has the return button but it gives me the error "Can't find enough targets" which is the error message for this ability. I've included my map so that you may be able to look and quickly find the issue.
Having looked at your map the fault is the Ability - Abilities - Ability field of your units. You need to update it to include your custom abilities because there is no point linking the command card to an ability the unit does not have.
The disabling validator in your Buff behaviour is also incorrect.
The worker harvest lumber abilities (the 4) have to be there, 2 for mining and 2 for return otherwise it won't work.
Do you mean (Basic)Behavior: Validators (Disable) for PeasantHarvestLumberModeOn behavior? The goldish text is all blizzard. What should the disable be?
The buff is disabled if the unit is not actively using a specific ability. In your super worker version you are using a different ability causing the buff to be disabled and not work.
I'm not quite sure what you mean. "PeasantHarvestLumberModeOn" has the disable validator but both workers have that behavior. What ability does the super worker have that the regular worker does not?
Are you or are you not using a copy of the ability for the super workers? Or are you saying the two different units with the same ability is giving problems?
Rollback Post to RevisionRollBack
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
I want the two units (eventually 5) to have the abilities. "Worker Harvest Lumber", "Worker Harvest Lumber Directed", "Worker Harvest Lumber Return", and "Worker Harvest Lumber Return Search". So I am not going to use the copied super worker abilities as I tried and it failed to work as well.
Since "Worker Harvest Lumber Return" actually contains what a unit will return, after I duplicated the ability, I figured I could just change the return cargo effects and validators inside the mentioned ability.
So both units have the same abilities but the "Worker Harvest Lumber Return" has more effects and validators because it is what gives the lumber and I want all 5 (currently 2) units to return different amounts. But they will all harvest at the same speed and everything. It is this ability that is giving me trouble because it doesn't seem to know what to do.
As stated the directed lumber harvest uses a Buff behaviour on the units that is validated if the unit is using the correct ability and that validator is used for other effects in the ability. Any copies and duplicates will need to be altered to use a different validator.
Rollback Post to RevisionRollBack
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
I'm not sure what you mean. The behavior "PeasantHarvestLumberModeOn" for "Worker Harvest Lumber Directed" does have a disable validator but both units use it. The unit does collect stacks of lumber, thus "Carry Lumber" behavior is being applied to them. I assume you mean the "InPeasantHarvestLumberOrder" validator. But that only links to other abilities. If it is this, how do I change it?
I am not that great at the data editor, but the worker seems to be mining, it just won't return the cargo it seems.
Worker Lumber Harvest: Uses the PeasantHarvestLumber Set type effect which applies the PeasantHarvestLumberModeOn Buff behaviour and an Issue Order effect to use the PeasantHarvestLumberTreeSearch (Unnamed) ability. Please note how it is not using orthogonal effects from what you copied. The Buff is disabled if InPeasantHarvestLumberOrder (Unnamed) is not met and that requires one of the four Peasant related abilities to be used. Note you have not changed them for the worker while your In Super Worker Harvest Lumber Order validator is not used by anything. The buff uses a periodic Search Area effect that uses an Issue Order effect which you have updated to use Worker Harvest Lumber Directed.
Worker Harvest Lumber Directed: Uses the PeasantHarvestLumberDirected (Unnamed) Set type effect that also applies the same PeasantHarvestLumberModeOn Buff behaviour and a PeasantHarvestLumberCP (Unnamed) Create Persistent effect that initially and periodically creates a second PeasantHarvestLumberGainCP (Unnamed) periodic effect. The second persistent effect goes through a series of validated effects (a Switch could have been used). Again your Unit Compare Behaviour Count validators are not connected up (Super Worker Lumber). With the first effect of the periodic it compares buff stacks and uses a thirs Create Persistent that lead to two Issue Order effects . The IsPeasantLumberDropOff validator is probably a Unit Type validator and the cause of your current issues. The second periodic effect is if the tree is dead and the worker is not full which is an issue order to recast the ability on the next tree. Third is a dummy Modify Unit effect probably for the actor events of the tree and the fourth is a set to damage the tree (you have modified to not damage the tree) and to apply a buff stack. The fifth and sixth periodic are a repeat of the first two. With the PeasantMaxLumberCarryReturnCP (Unnamed) persistent it orders the unit to use the Worker Harvest Lumber Return ability on a drop off structure if full else PeasantHarvestLumberTreeSearch (Unnamed) to find a new tree. Note again you have not linked to your copy properly.
Worker Harvest Lumber Return: For some reason you have this set up as a levelled ability with Super Worker Harvest Lumber Return at ability level 2 otherwise it uses the peasant version of the effect tree. All this effect does is a Switch effect based on the number of lumber Buff stacks the unit has. This switch uses various Set effects that use Modify Player effects to add the correct resource amount and a Remove Behavior effect to purge the unit of remaining lumber stacks.
Worker Harvest Lumber Return Search: A fail safe ability that if there is nothing to harvest it will use a Search Area effect with map wide radius to find a drop off and use an Issue Order effect to use Worker Harvest Lumber Return.
Overall diagnostic is you have not linked up your copied effects/validators into the effect trees and you have not updated IsPeasantLumberDropOff (Unnamed) to include new drop off units. Also you are modifying the same default effects at the terminus of the effect tree so modifying all copies of the ability.
The "Super Worker Harvest xxx" (xxx is anything after) isn't supposed to go to anything. I tried to originally copy the original blizzard stuff and linked it but it didn't work so I scraped it and then unlinked from the original blizzard stuff. I didn't delete it because I was going to do it later, ignore all Super Worker xxx stuff.
The only Super Worker anything that should be seen is the unit, not effects abilities validators ect. I want the super worker to operate just like the worker, and as such I linked only the super worker to the abilities of the regular worker. So both units have 4 abilities, the same abilities -- which is what I want. The only difference is in "Worker Harvest Lumber Return" which has a seperate "Super Worker xxx" stuff because it harvests and has a larger cargo than the regular worker.
The "IsPeasantLumberDropOff" just validates that the peasant(worker) is indeed not a drop off. It will have to go do a keep,castle, town hall, or lumber mill. In which case I want to keep that.
I will delete all super worker stuff that I don't need and reupload map. Updated Map Here
I will give you a run down of all the problems for each ability again.
Worker Harvest Lumber: Applies the PeasantHarvestLumberModeOn (Unnamed) buff that is validated to use InPeasantHarvestLumberOrder (Unnamed) which uses InPeasantHarvestLumberTreeSearchOrder (Unnamed). This validator has not been updated to use one of your worker abilities.
Worker Harvest Lumber Return: Under the Effect: Effect field remove the effect for the second level. The PeasantHarvestLumberReturn (Unnamed) effect has an unnecessary validator.
Edit: Having looked at the mod some more a lot of abilities look incomplete so are you sure the default lumber harvest works correctly?
I have removed "InPeasantHarvestLumberTreeSearchOrder (Unnamed)" from the validator "InPeastantHarvestLumberOrder (unnamed)" and the worker still works correctly, and the super worker still doesn't work correctly. By that I mean it still harvests trees but doesn't return cargo.
For the "Worker Harvest Lumber Return" I want both of the effects "PeasantHarvestLumberReturn (Unnamed)" and "Super Worker Harvest Lumber Return". I put in a unit type validator so that it won't apply both effects, and it would check the unit. The previous two effects apply the effect "LumberxSet" or"Super Worker Lumber x Set" after the unit type validator checks the unit. Then another validator checks the cargo of lumber and then applies "LumberxResources" or "Super Worker Lumber x". Based on how much cargo the unit has, it will give the player x amount of lumber determined in the previous two effects. For testing purposes I set the "Lumber1Resources" and "Super Worker Lumber 1" to 2000 and 50000 respectfully. This way I can check if it is differentiating between the effects.
If I am correct however, upon the use of the ability "Worker Harvest Lumber Return", both effects should be put on the unit, but both have validator for unit types. Which means only 1 will actually take effect. These effects are what set the lumber gained from the stacks of lumber. For instance a worker will return 2000,2,3,4,5,6,7,8,9,10. And the super worker will return 50000,2,3,4,5,6,7,8,9,10. Where 2000 and 50000 is for testing only, and it won't be the final values. If this is not correct, how should I make it?
The mod isn't perfect, but it's mostly because the command card and abilities aren't set properly for some reason. However these abilities should be, I think. At least for the regular worker it is correct. If you test the document, and right click a tree, 10 seconds later the worker will return 10 lumber. Meanwhile the super worker will harvest the tree and apply the carry lumber behavior but won't return. I checked to see if it applies the behavior by setting it to display behaviors on the unit.
So instead of the Switch effects "PeasantHarvestLumberReturn" and "Super Worker Harvest Lumber Return" they should be set effects? So do I replace those two effects for a newly created set effect?
Or should I make a set effect and link to ability, and put those two switch effects inside of it with the unit type validators staying how they are?
Or would another switch effect work, where in the cases I put the two effects "PeasantHarvestLumberReturn" and "Super Worker Harvest Lumber Return" inside the newly created switch effect with the validators being the unit type?
Edit: I've made another switch effect with the unit type validator and under cases I put the other 2 switch effects (the above). And it now works.
So the issue I am having is trying to use wc3 data mod to change harvest amount. There will be 5 different workers and the only thing that changes is the amount at which they return per "cargo" or "lumber stack" which appears to be controlled by the number of behavior stacks on the unit. Scroll down for a TL;DR :D
Things I want:
1) The 5 different workers will have different harvest amount per stack of lumber. But everything else should be the same, including the behavior and effects to get the stacks of lumber and the processes involved. (Or so I think)
2) I will have 3 upgrades that change the amount that is harvested. Which I could do in upgrades that change the effect "super worker lumber 1" and "worker lumber 1" Basic Effect: Resources to the new value per upgrade. (I've only listed 2 because I haven't done the other 3 because I am trying to at least get the super worker to work correctly). Since each worker will only hit the tree 10 times, I have to hard 'code' the harvested values because some will have decimals and I haven't have .5 behavior on a unit.
4) A person should be able to right click a tree to initiate the harvesting or by clicking the ability. Both of these work in wc3 and in sc2. I've figured out that both "Worker Harvest Lumber" and "Worker Harvest Lumber Directed" must be in the abilities for the unit to achieve this result. I've tried to merge the two without any luck. Also I wanted the return of cargo to not be displayed unless you actually have cargo, which "Worker Harvest Lumber Return Search" does, but without the "Worker Harvest Lumber Return" it will get an error. Effectively all 4 of these abilities need to be on the unit with only "Worker Harvest Lumber Directed" and "Worker Harvest Lumber Return Search" being used in the command card.
5) Only the peasant "Worker" has the animation of lumber on his shoulder, the rest do not, but they have the attack animation of attacking the tree. I think I've done this correctly.
* 6) Not really something I want to change or even would even matter, but Blizzard set the harvest ability to damage the tree, I changed it to do 0 damage to a tree, thus never killing it and allowing it to be harvested for an infinite amount. However they also include a "tree dead" validator and effect, which seems useless to me since it will never die. I don't know if removing this will change things, but I do not care too much since it won't affect the process at all in this scenario.
Methods tried:
1) I've tried copying the whole peasant unit (which I called "worker" now) including all effects and behaviors after I tested the command card and abilities and the "worker" does exactly what I want it to do. The copying didn't copy some of the sub effects, sub validators, etc. so I had to just copy the ones that were missing and relink them. After that was done I tried putting the new abilities on the "super worker" unit. The "super worker" does 'attack' the tree but it doesn't return or even get lumber. I assume it's because the behavior isn't being applied.
2) I've instead tried to do a smarter approach. Since the only thing that differs between the 5 workers are the amount in which they gather, I've tried to change the effects inside the ability "worker harvest lumber return" as it is that ability that actually sets the lumber you get based on the stacks of lumber harvested. So using the last method I had the copy of the "Super worker lumber 1 set" effects. I then tried to put a unit type validator on that effect should only use that effect if the unit type is what I want. The same probably occurs as the last one, the "worker" works fine, but the "super worker" does not.
3) I've also tried to create my own to simplify Blizzard's way of doing this process but I cannot seem to grasp the moving parts of all of this :(
I've included the test map that diverged from the original which is basically the same without 1 ability that I removed, I think it was "Worker Harvest Lumber Return" as I merged it with the "Worker Harvest Lumber Return". Also The "Super Worker" has the attack animation to the tree and if I right click a tree it will activate the harvest process. It just doesn't return it.
TL;DR: I want to be keep the method in which 5 different workers harvest trees. The only thing I want to change is how much they harvest, but the method stays the same. I assume a validator needs to be used, which I tried but the "Super Worker" doesn't return cargo, or even have cargo like the "Worker" does.
Down Map Here
Thanks!
1. Why not just do like the mule and use the Stats: Resource Amount Bonus field of the Harvest ability to set how much to return each?
2. How is this ability set up?
3. There is nothing for 3 under things you want.
4. Just use the Smart Command flag for the ability
5. There is a wood bundle model that you could always attach to the other unit models.
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
Thank you DrSuperEvil for you response. However that doesn't solve the issue of 5 different units harvesting different amounts and how to link it to what Blizzard has set.
1) Isn't unit dependant. It is based off the ability, Blizzard has wc3 units split their gather and return cargo. Even if I were to change that field, it would only change the ability's bonus which would be applied on all 5 units.
2) The ability harvest basically applies a buff. When it has max lumber stacks (10) it will return the cargo. Then the buff is counted which is basically how many stacks of lumber it has. And it somehow checks and matches with the effect "worker lumber x", where x is a number and it will give lumber to the player based on what is inside "worker lumber x set". This is a simplified way of what it is doing but there are effects upon effects and I'm not sure what it does.
4) I'll try smart command.
5) I'm not saying I want the bundle, just that other units should not have it.
In reply to DrSuperEvil:
First do both workers share the same abilities? Second are any Unit Type validators used at any point in the effect tree?
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
In reply to DrSuperEvil:
Yes, both workers use the same 4 abilities. Yes, there are unit type validators that I put in for the return cargo. However unit type validators aren't anywhere else. Upon testing, using triggers to give the buff to the worker, it doesn't return. However it can't be because of the validator because the regular worker still works, but the super worker does not return. The button to return cargo doesn't even show up.Edit: I think the problem lies somewhere in "Worker Harvest Lumber Return Search"If I remove the unit type validator the super worker will harvest like the regular worker. However the button still doesn't appear and I don't want it to mine like the regular worker.
I have appeared to narrow it down by a lot. "Worker Harvest Lumber Return Search" seems to be where the issue is coming from. I have played around with things and now the super worker has the return button but it gives me the error "Can't find enough targets" which is the error message for this ability. I've included my map so that you may be able to look and quickly find the issue.Download Map Here
Having looked at your map the fault is the Ability - Abilities - Ability field of your units. You need to update it to include your custom abilities because there is no point linking the command card to an ability the unit does not have.
The disabling validator in your Buff behaviour is also incorrect.
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
The worker harvest lumber abilities (the 4) have to be there, 2 for mining and 2 for return otherwise it won't work.
Do you mean (Basic)Behavior: Validators (Disable) for PeasantHarvestLumberModeOn behavior? The goldish text is all blizzard. What should the disable be?
The buff is disabled if the unit is not actively using a specific ability. In your super worker version you are using a different ability causing the buff to be disabled and not work.
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
In reply to DrSuperEvil:
Are you or are you not using a copy of the ability for the super workers? Or are you saying the two different units with the same ability is giving problems?
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
In reply to DrSuperEvil:
Since "Worker Harvest Lumber Return" actually contains what a unit will return, after I duplicated the ability, I figured I could just change the return cargo effects and validators inside the mentioned ability.
So both units have the same abilities but the "Worker Harvest Lumber Return" has more effects and validators because it is what gives the lumber and I want all 5 (currently 2) units to return different amounts. But they will all harvest at the same speed and everything. It is this ability that is giving me trouble because it doesn't seem to know what to do.
As stated the directed lumber harvest uses a Buff behaviour on the units that is validated if the unit is using the correct ability and that validator is used for other effects in the ability. Any copies and duplicates will need to be altered to use a different validator.
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
In reply to DrSuperEvil:
I am not that great at the data editor, but the worker seems to be mining, it just won't return the cargo it seems.
Here is how the abilities are working.
Worker Lumber Harvest: Uses the PeasantHarvestLumber Set type effect which applies the PeasantHarvestLumberModeOn Buff behaviour and an Issue Order effect to use the PeasantHarvestLumberTreeSearch (Unnamed) ability. Please note how it is not using orthogonal effects from what you copied. The Buff is disabled if InPeasantHarvestLumberOrder (Unnamed) is not met and that requires one of the four Peasant related abilities to be used. Note you have not changed them for the worker while your In Super Worker Harvest Lumber Order validator is not used by anything. The buff uses a periodic Search Area effect that uses an Issue Order effect which you have updated to use Worker Harvest Lumber Directed.
Worker Harvest Lumber Directed: Uses the PeasantHarvestLumberDirected (Unnamed) Set type effect that also applies the same PeasantHarvestLumberModeOn Buff behaviour and a PeasantHarvestLumberCP (Unnamed) Create Persistent effect that initially and periodically creates a second PeasantHarvestLumberGainCP (Unnamed) periodic effect. The second persistent effect goes through a series of validated effects (a Switch could have been used). Again your Unit Compare Behaviour Count validators are not connected up (Super Worker Lumber). With the first effect of the periodic it compares buff stacks and uses a thirs Create Persistent that lead to two Issue Order effects . The IsPeasantLumberDropOff validator is probably a Unit Type validator and the cause of your current issues. The second periodic effect is if the tree is dead and the worker is not full which is an issue order to recast the ability on the next tree. Third is a dummy Modify Unit effect probably for the actor events of the tree and the fourth is a set to damage the tree (you have modified to not damage the tree) and to apply a buff stack. The fifth and sixth periodic are a repeat of the first two. With the PeasantMaxLumberCarryReturnCP (Unnamed) persistent it orders the unit to use the Worker Harvest Lumber Return ability on a drop off structure if full else PeasantHarvestLumberTreeSearch (Unnamed) to find a new tree. Note again you have not linked to your copy properly.
Worker Harvest Lumber Return: For some reason you have this set up as a levelled ability with Super Worker Harvest Lumber Return at ability level 2 otherwise it uses the peasant version of the effect tree. All this effect does is a Switch effect based on the number of lumber Buff stacks the unit has. This switch uses various Set effects that use Modify Player effects to add the correct resource amount and a Remove Behavior effect to purge the unit of remaining lumber stacks.
Worker Harvest Lumber Return Search: A fail safe ability that if there is nothing to harvest it will use a Search Area effect with map wide radius to find a drop off and use an Issue Order effect to use Worker Harvest Lumber Return.
Overall diagnostic is you have not linked up your copied effects/validators into the effect trees and you have not updated IsPeasantLumberDropOff (Unnamed) to include new drop off units. Also you are modifying the same default effects at the terminus of the effect tree so modifying all copies of the ability.
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
In reply to DrSuperEvil:
The only Super Worker anything that should be seen is the unit, not effects abilities validators ect. I want the super worker to operate just like the worker, and as such I linked only the super worker to the abilities of the regular worker. So both units have 4 abilities, the same abilities -- which is what I want. The only difference is in "Worker Harvest Lumber Return" which has a seperate "Super Worker xxx" stuff because it harvests and has a larger cargo than the regular worker.
The "IsPeasantLumberDropOff" just validates that the peasant(worker) is indeed not a drop off. It will have to go do a keep,castle, town hall, or lumber mill. In which case I want to keep that.
I will delete all super worker stuff that I don't need and reupload map.
Updated Map Here
I will give you a run down of all the problems for each ability again.
Worker Harvest Lumber: Applies the PeasantHarvestLumberModeOn (Unnamed) buff that is validated to use InPeasantHarvestLumberOrder (Unnamed) which uses InPeasantHarvestLumberTreeSearchOrder (Unnamed). This validator has not been updated to use one of your worker abilities.
Worker Harvest Lumber Return: Under the Effect: Effect field remove the effect for the second level. The PeasantHarvestLumberReturn (Unnamed) effect has an unnecessary validator.
Edit: Having looked at the mod some more a lot of abilities look incomplete so are you sure the default lumber harvest works correctly?
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
In reply to DrSuperEvil:
For the "Worker Harvest Lumber Return" I want both of the effects "PeasantHarvestLumberReturn (Unnamed)" and "Super Worker Harvest Lumber Return". I put in a unit type validator so that it won't apply both effects, and it would check the unit. The previous two effects apply the effect "LumberxSet" or"Super Worker Lumber x Set" after the unit type validator checks the unit. Then another validator checks the cargo of lumber and then applies "LumberxResources" or "Super Worker Lumber x". Based on how much cargo the unit has, it will give the player x amount of lumber determined in the previous two effects. For testing purposes I set the "Lumber1Resources" and "Super Worker Lumber 1" to 2000 and 50000 respectfully. This way I can check if it is differentiating between the effects.
If I am correct however, upon the use of the ability "Worker Harvest Lumber Return", both effects should be put on the unit, but both have validator for unit types. Which means only 1 will actually take effect. These effects are what set the lumber gained from the stacks of lumber. For instance a worker will return 2000,2,3,4,5,6,7,8,9,10. And the super worker will return 50000,2,3,4,5,6,7,8,9,10. Where 2000 and 50000 is for testing only, and it won't be the final values. If this is not correct, how should I make it?
The mod isn't perfect, but it's mostly because the command card and abilities aren't set properly for some reason. However these abilities should be, I think. At least for the regular worker it is correct. If you test the document, and right click a tree, 10 seconds later the worker will return 10 lumber. Meanwhile the super worker will harvest the tree and apply the carry lumber behavior but won't return. I checked to see if it applies the behavior by setting it to display behaviors on the unit.
Use a Set effect from the ability then since adding multiple indices to an ability is only useful if you are using a Learn Ability to level them up.
Contribute to the wiki (Wiki button at top of page) Considered easy altering of the unit textures?
https://www.sc2mapster.com/forums/resources/tutorials/179654-data-actor-events-message-texture-select-by-id
https://media.forgecdn.net/attachments/187/40/Screenshot2011-04-17_09_16_21.jpg
So instead of the Switch effects "PeasantHarvestLumberReturn" and "Super Worker Harvest Lumber Return" they should be set effects? So do I replace those two effects for a newly created set effect?Or should I make a set effect and link to ability, and put those two switch effects inside of it with the unit type validators staying how they are?Or would another switch effect work, where in the cases I put the two effects "PeasantHarvestLumberReturn" and "Super Worker Harvest Lumber Return" inside the newly created switch effect with the validators being the unit type?Edit: I've made another switch effect with the unit type validator and under cases I put the other 2 switch effects (the above). And it now works.
Thank you DrSuperEvil!!!