SC2Mapster

Somewhere somehow I managed to screw up my income triggers So if someone can point out where or how I failed it would help.

Protosss Pick P1
    Events
        Dialog - Any Dialog Item is used by Player 1 with event type Checked
    Local Variables
    Conditions
        (Dialog Check Toss is checked for (Triggering player)) == true
    Actions
        Unit - Create 1 Protoss Builder for player 1 at (Center of Player 1 Spawn) using default facing (No Options)
        Unit - Add 1 rounds of ammo to Ghost Academy - Arm Silo with Nuke magazine for (Last created unit)
        Camera - Pan the camera for player 1 to (Center of Player 1 Spawn) over 2.0 seconds with Existing Velocity% initial velocity, 10% deceleration, and Do use smart panning
        Dialog - Destroy all items for Diablog Box 1
        Dialog - Destroy all dialogs
        Variable - Set Player 1 Race = "Protoss"
        Timer - Start (New timer) as a Repeating timer that will expire in 30.0 Game Time seconds
        Variable - Set Player 1 timer = (Last started timer)
        Variable - Set Player 1 timer integer = 30

The timer trigger used to be in map initialization I moved it trying to fix it. Here is the update trigger.

Player 1 Income
    Events
        Timer - Player 1 timer expires
    Local Variables
    Conditions
    Actions
        Player - Modify player 1 Minerals: Add Player 1 Income

I don't see anything odd. I'm missing a few variables, but I assume they are in your map. What exactly does not work? Try showing the timer if that's the problem.

@Berrala: Go

I did show the timer. For some reason the event in the second trigger the one that adds minerals isn't firing. At all. I even remade the trigger. Is it a blizzard bug where the timer doesn't actually hit 0 and just restarts at the designated time?

You could try to send some chat text in the timer expires trigger, see if it fires at all, or just the mineral add don't work. I assume you checked the variable you are adding income with so it's not 0 or something. You could also test making the timer one shot only, see if it adds income once at least. Basically, narrow it down as much as you can. Hard to guess here when I'm not seeing everything in front of me in the editor.

@Berrala: Go

Yeah the integer starts out at 10 and I did add a transmission to play hen it triggered and none of them worked hen I made it a 30 second period thing it worked. That is what I have it set as no for testing purposes.

So.. I'm confused, it's working now.. but only for testing purposes? Something you want to change, but then it doesn't work?

Maybe you could try making it an one-time timer, and then remaking it when it expires.

Ok, I've been playing around with timers a bit. Apparently you shouldn't start a new timer. Make a global variable (timer). Start that timer. No need to assign it to a variable after, in fact, that seems to be what's breaking it. Anyway, this works:

Global variable:
mytimer = (New timer) <Timer>

Trigger 1:
    Events
        Game - Map initialization
    Local Variables
    Conditions
    Actions
        Timer - Start mytimer as a Repeating timer that will expire in 5.0 Game Time seconds

Trigger 2:
    Events
        Timer - mytimer expires
    Local Variables
    Conditions
    Actions
        UI - Display "Restart" for (All players) to Chat area

@Berrala: Go

Ok that makes sense. Stupid question though. Can I modify it after I start it to make it longer or shorter? Thanks by the way. Sorry I forgot to check the forum before work earlier.

Nevermind I was tired and asn't thinking straight all I'd have to use is the same action again only changing the time. Thanks I'll test it out now and post an edit if it works.

Ok that works. Theres a new issue though. No when it updates it updates it twice so people are getting double income >.<

Nevermind I had it firing twice.

Definitely impossible for me to fix without seeing the current code. My guess is that you forgot to delete a duplicate trigger or something when you were testing. My mini-timer-map did no such thing. Look around a bit before you rush back to the forums. I saw your earlier edit and kind of didn't even bother answering that... :-p

Edit: haha, called it!