Need help with "Open Bank" ....

#1 Jul 26, 2010

_ForgeUser4448192

Join Date: 5/19/2010
Posts: 36
Member Details

Hi there, i have a problem with my Save-Load Funktions... and i have no idea what i did wrong :D It used to work a while ago, but now it does not... nothing is restored and i don´t know where the mistake is....

Ok First Trigger : We need to preload, or else it doesn´t load after restarting the game :

**PreLoad Bank**
    Events
        Game - Map initialization
    Local Variables
    Conditions
    Actions
        Bank - Preload and synchronize bank "NimoSaveGhost" for player 1
        Bank - Preload and synchronize bank "NimoSaveGhost" for player 2
... (and so on, there are 3 Classes and 3 Players, and you can´t use Variables, so this should be ok)

-------------------------

**Save GHOST** (This trigger saves the Unit its Items, and its Skills (in form of integers)
    Events
        Game - Player Any Player types a chat message containing "SaveGhost", matching Exactly
    Local Variables
        Player = (Owner of Hero GHOST) <Integer>
        Carried Items = (Empty unit group) <Unit Group[10]>
        x = 1 <Integer>
        y = 0 <Integer>
        ItemCount = 0 <Integer>
    Conditions
    Actions
        Bank - Open bank "NimoSaveGhost" for player Player
        Bank - Store unit Hero GHOST as "GHOST" of section "HEROES" in bank (Last opened bank)
        ------- Comment
        Bank - Store unit Heroes[Player] as "Hero" of section "Heroes" in bank (Last opened bank)
        Unit Group - Add all units in (All items carried by Heroes[Player]) to Carried Items[Player]
        Variable - Set ItemCount = (Number of Any units in Carried Items[Player])
        General - For each integer y from 0 to 10 with increment 1, do (Actions)
            Actions
                Bank - Store unit (Unit x from Carried Items[Player]) as ("Item" + (String(x))) of section "Items" in bank (Last opened bank)
                Variable - Modify x: + 1
        Bank - Store integer ItemCount as "ItemCount" of section "Items" in bank (Last opened bank)
        ------- Comment
        SAVE Integer Variable(Player, (Last opened bank))
        ------- Comment
        General - Wait 2.0 Game Time seconds
        Bank - Save bank (Last opened bank)
        UI - Display ("Saved for " + (Name of player (Owner of Hero GHOST))) for (All players) to Subtitle area

-------------------

So far so good, no Errors in this Trigger (at least it says so :D )

And then the Load Trigger :

**load Player 1**
    Events
        Game - Player Any Player types a chat message containing "LoadGhost", matching Exactly
    Local Variables
        Player = 1 <Integer>
        x = 1 <Integer>
        y = 0 <Integer>
        Items to be loaded = No Unit <Unit>
    Conditions
    Actions
        ------- Comment
        Bank - Open bank "NimoSaveGhost" for player 1
        UI - Display ("Loading for " + (Name of player Player)) for (All players) to Subtitle area
        General - Wait 1.0 Game Time seconds
        Bank - Restore "Hero" of section "Heroes" from bank (Last opened bank) for player Player at (Center of Deckung 1 A) facing 0.0
        General - If (Conditions) then do (Actions) else do (Actions)
            If
                (Unit type of (Last restored unit)) == Hero -  Ghost
            Then
                Variable - Set Hero GHOST = (Last restored unit)
                Unit - Set (Last restored unit) Movement Speed to 0.0
                Unit - Disable the Move ability for (Last restored unit)
                ------- Comment
                Variable - Set Ress Energiezellen[Player] = (Load "Energiecell" of section "Ress" from bank (Last opened bank) as integer value)
                Variable - Set Ress Metalle[Player] = (Load "Metal" of section "Ress" from bank (Last opened bank) as integer value)
                Dialog - Set Dialog Item Ressourcen[Player][0] text to (Text(Ress Metalle[Player])) for (Player group(Player))
                Dialog - Set Dialog Item Ressourcen[Player][1] text to (Text(Ress Energiezellen[Player])) for (Player group(Player))
                Variable - Set Integer Level Upgrade Schaden GhostWaffe1[Player] = (Load "WaffeGhost1Schaden" of section "Items" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade Schaden GhostWaffe2[Player] = (Load "WaffeGhost2Schaden" of section "Items" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SchildundPanzer GhostWaffe1[Player] = (Load "WaffeGhost1ShieldBonus" of section "Items" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade Qucikdraw GhostWaffe2[Player] = (Load "WaffeGhost1Quickdraw" of section "Items" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade Reichweite GhostWaffe1[Player] = (Load "WaffeGhost1Range" of section "Items" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade Hitpoints Ghost[Player] = (Load "GhostHP" of section "Upgrade" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost1[Player] = (Load "SkillGhost1" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost1 Range[Player] = (Load "SkillGhost1Range" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost2[Player] = (Load "SkillGhost2" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost3[Player] = (Load "SkillGhost3" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost4[Player] = (Load "SkillGhost4" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost5[Player] = (Load "SkillGhost5" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost6[Player] = (Load "SkillGhost6" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost7[Player] = (Load "SkillGhost7" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Integer Level Upgrade SkillGhost8[Player] = (Load "SkillGhost8" of section "Skills" from bank (Last opened bank) as integer value)
                Variable - Set Tarnenergie pro Runde = (Load "Tarnenergie" of section "Skills" from bank (Last opened bank) as integer value)
                ------- Comment
                General - Wait 1.0 Game Time seconds
                Variable - Set Heroes[Player] = (Last restored unit)
                Trigger - Run Load P2 WaffeGhost1 Schaden  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 WaffeGhost2 Schaden  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 WaffeGhost1 SchieldPanzer  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 WaffeGhost1 Range  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 Hitpoints   (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 WaffeGhost1 Quickdraw  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost1  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost1 Range  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost2  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost3  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost4  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost5  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost6  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost7  (Ignore Conditions, Don't Wait until it finishes)
                Trigger - Run Load P2 SkillGhost8  (Ignore Conditions, Don't Wait until it finishes)
            Else
        General - Wait 1.0 Game Time seconds
        Unit Group - Add Heroes[Player] to HeroesUnitGroup
        ------- Comment
        Player - Modify player Player Minerals: Set To (Load "Mineral" of section "Ress" from bank (Last opened bank) as integer value)
        Player - Modify player Player Vespene: Set To (Load "Vespene" of section "Ress" from bank (Last opened bank) as integer value)
        General - For each integer y from 1 to (Load "count" of section "Items" from bank (Last opened bank) as integer value) with increment 1, do (Actions)
            Actions
                Bank - Restore ("Item" + (String(x))) of section "Items" from bank (Last opened bank) for player Player at (Position of Heroes[Player]) facing 0.0
                Variable - Set Items to be loaded = (Last restored unit)
                Unit - Create one (Unit type of (Last restored unit)) item in the inventory of Heroes[Player]
                Unit - Remove Items to be loaded from the game
                Variable - Modify x: + 1
        UI - Display ("Loading complete" + (Name of player Player)) for (All players) to Subtitle area
        ------- Comment

-----------------

And there i get an TriggerError "could not get "bank" from paramenter in (value) ", and i have NO clue why. It doesn´t matter if i restart the map or do it in the same session, it won´t restore anything. But the Bank got saved, i have the File on my HDD (C:\Users\MyName\Documents\StarCraft II Beta\Banks), and when i open it, there is everything in there...

Last edited by _ForgeUser4448192: Jul 26, 2010

#2 Jul 26, 2010
_ForgeUser466359
_ForgeUser466359

View User Profile

View Posts

Send Message
- Join Date: 2/4/2008
- Posts: 4
- Member Details
In your save trigger, you have the line:
Bank - Open bank "NimoSaveGhost" for player Player

When you open a bank, you can't use a variable for the player number, you need to change this line to:

Bank - Open bank "NimoSaveGhost" for player 1

You'll probably want to put these into the same trigger as your preload statements. Also, you'll have to make a global bank array ( I called it BankSaveFile ) to hold these:

Bank - Open bank "NimoSaveGhost" for player 1
Variable - Set variable BankSaveFile[1] = (Last opened bank)
Bank - Open bank "NimoSaveGhost" for player 2
Variable - Set variable BankSaveFile[2] = (Last opened bank)
Bank - Open bank "NimoSaveGhost" for player 3
Variable - Set variable BankSaveFile[3] = (Last opened bank)
etc..

Then reference them in your save trigger wherever you have (Last opened bank), use BankSaveFile[Player] instead.

Last edited by _ForgeUser466359: Jul 26, 2010

Rollback Post to Revision RollBack
#3 Jul 26, 2010
_ForgeUser4448192
_ForgeUser4448192

View User Profile

View Posts

Send Message
- Join Date: 5/19/2010
- Posts: 36
- Member Details
@Glynn: Go

Hi, well , the problem is not the Save Trigger, as i have the XML File on my harddisk, and it is everything in there that i wanted to be saved (all integers, all units and so on...) The Problem is the Load Trigger...

And i had global Bank Arrays before, didn´t work either, thats why i changed it, but it did not help anything :D.

Last edited by _ForgeUser4448192: Jul 26, 2010

Rollback Post to Revision RollBack
#4 Jul 26, 2010
_ForgeUser466359
_ForgeUser466359

View User Profile

View Posts

Send Message
- Join Date: 2/4/2008
- Posts: 4
- Member Details
Try moving the XML file and see if it's recreated if you run the map and try to save.

Also, are you saving some info in another trigger? There are quite a few load statements that load from sections that aren't saved in your save trigger.

You're saving the number of items under "ItemCount", but loading as "count".. the names need to be the same for it to work.

Rollback Post to Revision RollBack
#5 Jul 26, 2010
_ForgeUser4329264
_ForgeUser4329264

View User Profile

View Posts

Send Message
- Join Date: 4/18/2010
- Posts: 28
- Member Details
Quote from Glynn: Go
When you open a bank, you can't use a variable for the player number, you need to change this line to:

Wait, what? Really?

Rollback Post to Revision RollBack

#7 Jul 26, 2010

_ForgeUser4448192

Join Date: 5/19/2010
Posts: 36
Member Details

@Glynn: Go

In the Save Trigger there is an Action Definition, ( SAVE Integer Variable(Player, (Last opened bank)) ) which does basicly nothing else than save all the Integer Values. I tried it both ways, with action defintion and as single ""save integer in bank" actions within the trigger, nothing changed. However, heres the Action definition :

SAVE Integer Variable
    Options: Action
    Return Type: (None)
    Parameters
        Player = 0 <Integer>
        Bank = No Bank <Bank>
    Grammar Text: SAVE Integer Variable(Player, Bank)
    Hint Text: (None)
    Custom Script Code
    Local Variables
    Actions
        Bank - Store integer (Player Player Minerals) as "Mineral" of section "Ress" in bank Bank
        Bank - Store integer (Player Player Vespene) as "Vespene" of section "Ress" in bank Bank
        Bank - Store integer Ress Energiezellen[Player] as "Energiecell" of section "Ress" in bank Bank
        Bank - Store integer Ress Metalle[Player] as "Metal" of section "Ress" in bank Bank
        Bank - Store integer Integer Level Upgrade Schaden GhostWaffe1[Player] as "WaffeGhost1Schaden" of section "Items" in bank Bank
        Bank - Store integer Integer Level Upgrade Schaden GhostWaffe2[Player] as "WaffeGhost2Schaden" of section "Items" in bank Bank
        Bank - Store integer Integer Level Upgrade SchildundPanzer GhostWaffe1[Player] as "WaffeGhost1ShieldBonus" of section "Items" in bank Bank
        Bank - Store integer Integer Level Upgrade Qucikdraw GhostWaffe2[Player] as "WaffeGhost1Quickdraw" of section "Items" in bank Bank
        Bank - Store integer Integer Level Upgrade Reichweite GhostWaffe1[Player] as "WaffeGhost1Range" of section "Items" in bank Bank
        Bank - Store integer Integer Level Upgrade Hitpoints Ghost[Player] as "GhostHP" of section "Upgrade" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost1[Player] as "SkillGhost1" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost1 Range[Player] as "SkillGhost1Range" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost2[Player] as "SkillGhost2" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost3[Player] as "SkillGhost3" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost4[Player] as "SkillGhost4" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost5[Player] as "SkillGhost5" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost6[Player] as "SkillGhost6" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost7[Player] as "SkillGhost7" of section "Skills" in bank Bank
        Bank - Store integer Integer Level Upgrade SkillGhost8[Player] as "SkillGhost8" of section "Skills" in bank Bank
        Bank - Store integer Tarnenergie pro Runde as "Tarnenergie" of section "Skills" in bank Bank

And i tested it : i deleted the XML, and it got recreated. I even tried a new trigger, in which i ONLY try to recreate the unit, but doens´t work either... i have no idea, maybe it works with the release version... well see tomorrow

#8 Jul 27, 2010
_ForgeUser4508858
_ForgeUser4508858

View User Profile

View Posts

Send Message
- Join Date: 6/4/2010
- Posts: 111
- Member Details
According to the Hive's bank tutorial, only the preload and synchronize can't use a player number. Variables work fine for everything else.

Last edited by _ForgeUser4508858: Jul 27, 2010

Rollback Post to Revision RollBack
#9 Jul 27, 2010
_ForgeUser4448192
_ForgeUser4448192

View User Profile

View Posts

Send Message
- Join Date: 5/19/2010
- Posts: 36
- Member Details
Ok, it was a simple, but annoying Bug. I simpy deleted the "restore Unit" Action in the Load trigger, createt a new one with EXACT the same paramenters, and its working again....

Well, case closed :D

Rollback Post to Revision RollBack
#10 Aug 24, 2010
_ForgeUser4553029
_ForgeUser4553029

View User Profile

View Posts

Send Message
- Join Date: 6/15/2010
- Posts: 128
- Member Details
Quote from Glynn:
When you open a bank, you can't use a variable for the player number, you need to change this line to:
----

Thanks for this. It's absolutely retarded you have to do this, but nothing a switch can't fix.

Rollback Post to Revision RollBack
#11 Sep 2, 2010
_ForgeUser4750049
_ForgeUser4750049

View User Profile

View Posts

Send Message
- Join Date: 7/22/2010
- Posts: 143
- Member Details
im havinga similar, but more issolated problem, my preload and sync trigger is working for some save files, but not all.

in my map i have 6 save files, for 12 players, and i was doing testing on my map in single player and files 1,2 4,6 will load, but 3 and 4 wont when i start a new game. but ALL of them work with saving/loading all the correct info in the same game, so im left to think it's the preload trigger at map initialization. but i've proof read it at least 10 times and i cant find inconsistencies. what could be causing this? I really need to know becase im making a ORPG and i dont want people to have to keep starting over because my save files arny loading =(

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Previous Thread

Next Thread